diff options
| author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2016-02-11 16:13:06 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-02-11 18:35:48 -0800 |
| commit | 078c6c3a5e7dc53a9a23408cc32c83954abb5d0d (patch) | |
| tree | e4185f03f3d35cc47c79b64323701dbe5370f8cc /mm | |
| parent | 6b9116a652bd9e0e2994505cfaaa5f66deaa2a05 (diff) | |
| download | blackbird-op-linux-078c6c3a5e7dc53a9a23408cc32c83954abb5d0d.tar.gz blackbird-op-linux-078c6c3a5e7dc53a9a23408cc32c83954abb5d0d.zip | |
mm/backing-dev.c: fix error path in wb_init()
We need to use post-decrement to get percpu_counter_destroy() called on
&wb->stat[0]. Moreover, the pre-decremebt would cause infinite
out-of-bounds accesses if the setup code failed at i==0.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/backing-dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 926c76d56388..c554d173a65f 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -328,7 +328,7 @@ static int wb_init(struct bdi_writeback *wb, struct backing_dev_info *bdi, return 0; out_destroy_stat: - while (--i) + while (i--) percpu_counter_destroy(&wb->stat[i]); fprop_local_destroy_percpu(&wb->completions); out_put_cong: |
