summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorRasmus Villemoes <linux@rasmusvillemoes.dk>2014-12-10 15:51:27 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2014-12-10 17:41:11 -0800
commit74a5fef7cb0839c6b595f90c7914a62ac9d0bcf9 (patch)
tree82e34b9120005a8a764d25f9c91b17ada4445b05 /lib
parent7b212edf86e28f4d0198f2152b2f0553f51a59a5 (diff)
downloadblackbird-op-linux-74a5fef7cb0839c6b595f90c7914a62ac9d0bcf9.tar.gz
blackbird-op-linux-74a5fef7cb0839c6b595f90c7914a62ac9d0bcf9.zip
lib/lcm.c: ensure correct result whenever it fits
Ensure that lcm(a,b) returns the mathematically correct result, provided it fits in an unsigned long. The current version returns garbage if a*b overflows, even if the final result would fit. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Cc: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/lcm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/lcm.c b/lib/lcm.c
index b9c8de461e9e..01b3aa922dda 100644
--- a/lib/lcm.c
+++ b/lib/lcm.c
@@ -7,7 +7,7 @@
unsigned long lcm(unsigned long a, unsigned long b)
{
if (a && b)
- return (a * b) / gcd(a, b);
+ return (a / gcd(a, b)) * b;
else if (b)
return b;
OpenPOWER on IntegriCloud