diff options
| author | Tejun Heo <tj@kernel.org> | 2017-03-06 15:33:42 -0500 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2017-03-06 15:33:42 -0500 |
| commit | 637fdbae60d6cb9f6e963c1079d7e0445c86ff7d (patch) | |
| tree | 3b785d958b7c02d45d3ce9e4076af530d0a34885 /kernel | |
| parent | c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201 (diff) | |
| download | blackbird-op-linux-637fdbae60d6cb9f6e963c1079d7e0445c86ff7d.tar.gz blackbird-op-linux-637fdbae60d6cb9f6e963c1079d7e0445c86ff7d.zip | |
workqueue: trigger WARN if queue_delayed_work() is called with NULL @wq
If queue_delayed_work() gets called with NULL @wq, the kernel will
oops asynchronuosly on timer expiration which isn't too helpful in
tracking down the offender. This actually happened with smc.
__queue_delayed_work() already does several input sanity checks
synchronously. Add NULL @wq check.
Reported-by: Dave Jones <davej@codemonkey.org.uk>
Link: http://lkml.kernel.org/r/20170227171439.jshx3qplflyrgcv7@codemonkey.org.uk
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/workqueue.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 072cbc9b175d..c0168b7da1ea 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1507,6 +1507,7 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq, struct timer_list *timer = &dwork->timer; struct work_struct *work = &dwork->work; + WARN_ON_ONCE(!wq); WARN_ON_ONCE(timer->function != delayed_work_timer_fn || timer->data != (unsigned long)dwork); WARN_ON_ONCE(timer_pending(timer)); |
