diff options
| author | Josef Bacik <jbacik@fb.com> | 2017-12-11 11:36:48 -0500 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2017-12-12 09:02:34 -0800 |
| commit | 9802d86585db91655c7d1929a4f6bbe0952ea88e (patch) | |
| tree | 53b334864518dd27b243eafc9ab510ac56ee3b74 /kernel/events | |
| parent | 8556e50994c8a8f5282fea008ae084d6d080648a (diff) | |
| download | blackbird-op-linux-9802d86585db91655c7d1929a4f6bbe0952ea88e.tar.gz blackbird-op-linux-9802d86585db91655c7d1929a4f6bbe0952ea88e.zip | |
bpf: add a bpf_override_function helper
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Accomplish this with the bpf_override_funciton
helper. This will modify the probe'd callers return value to the
specified value and set the PC to an override function that simply
returns, bypassing the originally probed function. This gives us a nice
clean way to implement systematic error injection for all of our code
paths.
Acked-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel/events')
| -rw-r--r-- | kernel/events/core.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c index f10609e539d4..5857c500721b 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8080,6 +8080,13 @@ static int perf_event_set_bpf_prog(struct perf_event *event, u32 prog_fd) return -EINVAL; } + /* Kprobe override only works for kprobes, not uprobes. */ + if (prog->kprobe_override && + !(event->tp_event->flags & TRACE_EVENT_FL_KPROBE)) { + bpf_prog_put(prog); + return -EINVAL; + } + if (is_tracepoint || is_syscall_tp) { int off = trace_event_get_offsets(event->tp_event); |
