diff options
author | David Woodhouse <dwmw2@infradead.org> | 2006-08-05 12:15:19 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-08-06 08:57:49 -0700 |
commit | 3e3183bab0257a6d02038658c53b491e1378612f (patch) | |
tree | 35221f1808e85674d9ba0ff93ce0cc4bce7edf7f /include | |
parent | 225add619624b4877941470f31d297e0151b21be (diff) | |
download | blackbird-op-linux-3e3183bab0257a6d02038658c53b491e1378612f.tar.gz blackbird-op-linux-3e3183bab0257a6d02038658c53b491e1378612f.zip |
[PATCH] SCX200_ACB: eliminate spurious timeout errors
While busy-waiting for completion, check the hardware after scheduling;
don't schedule and then immediately check the _timeout_. If the yield()
took a long time (as it does on my OLPC prototype board when it's busy),
we'd report a timeout even though the hardware was now ready.
This fixes it, and also switches the yield() for a cond_resched() because
we don't actually want to be _that_ nice about it. I see nice
tightly-packed SMBus transactions now, rather than waiting for milliseconds
between successive phases.
Actually, we shouldn't be busy-waiting here at all. We should be using
interrupts. That's an exercise for another day though.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Cc: Christer Weinigel <wingel@nano-system.com>
Cc: <Jordan.Crouse@amd.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions