summaryrefslogtreecommitdiffstats
path: root/include/scsi
diff options
context:
space:
mode:
author <jejb@titanic.il.steeleye.com>2005-04-12 16:38:09 -0500
committerJames Bottomley <jejb@titanic>2005-04-16 20:10:34 -0500
commitc2a9331c62216e222a08de8dd58559367fef0af6 (patch)
treef25b06ee61ffa8b000a45d0ec5f8a92ebb67f0ce /include/scsi
parent152587deb8903c0edf483a5b889f975bc6bea7e0 (diff)
downloadblackbird-op-linux-c2a9331c62216e222a08de8dd58559367fef0af6.tar.gz
blackbird-op-linux-c2a9331c62216e222a08de8dd58559367fef0af6.zip
updates for CFQ oops fix
- add a comment to the device structure that the device_busy field is now protected by the request_queue->queue_lock - null out sdev->request_queue after the queue is released to trap any (and there shouldn't be any) use after the queue is freed. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'include/scsi')
-rw-r--r--include/scsi/scsi_device.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index f6d051318299..fe9571d2e306 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -43,6 +43,7 @@ struct scsi_device {
struct list_head siblings; /* list of all devices on this host */
struct list_head same_target_siblings; /* just the devices sharing same target id */
+ /* this is now protected by the request_queue->queue_lock */
volatile unsigned short device_busy; /* commands actually active on low-level */
spinlock_t list_lock;
struct list_head cmd_list; /* queue of in use SCSI Command structures */
OpenPOWER on IntegriCloud