diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-02-19 12:13:13 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-02-20 17:35:14 -0500 |
| commit | 278f7b4fffce9ad267406cf8800df271d14f4a16 (patch) | |
| tree | 7998890a3cedcf7dab3edab58064306734d3707c /include/net/caif | |
| parent | 5a8eeec468f229558322926f28c61bb0769793e9 (diff) | |
| download | blackbird-op-linux-278f7b4fffce9ad267406cf8800df271d14f4a16.tar.gz blackbird-op-linux-278f7b4fffce9ad267406cf8800df271d14f4a16.zip | |
caif: fix a signedness bug in cfpkt_iterate()
The cfpkt_iterate() function can return -EPROTO on error, but the
function is a u16 so the negative value gets truncated to a positive
unsigned short. This causes a static checker warning.
The only caller which might care is cffrml_receive(), when it's checking
the frame checksum. I modified cffrml_receive() so that it never says
-EPROTO is a valid checksum.
Also this isn't ever going to be inlined so I removed the "inline".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/caif')
| -rw-r--r-- | include/net/caif/cfpkt.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/caif/cfpkt.h b/include/net/caif/cfpkt.h index 1c1ad46250d5..fe328c52c46b 100644 --- a/include/net/caif/cfpkt.h +++ b/include/net/caif/cfpkt.h @@ -171,7 +171,7 @@ struct cfpkt *cfpkt_split(struct cfpkt *pkt, u16 pos); * @return Checksum of buffer. */ -u16 cfpkt_iterate(struct cfpkt *pkt, +int cfpkt_iterate(struct cfpkt *pkt, u16 (*iter_func)(u16 chks, void *buf, u16 len), u16 data); |
