diff options
| author | Dave Chinner <dchinner@redhat.com> | 2016-08-26 16:01:30 +1000 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2016-08-26 16:01:30 +1000 |
| commit | f3d7ebdeb2c297bd26272384e955033493ca291c (patch) | |
| tree | 4624588ed7a3669e29a67e7e0e0f67770c5795d7 /fs | |
| parent | 5b5c2dbd3c9bcfa89fba9709c12ecc0a445c6e40 (diff) | |
| download | blackbird-op-linux-f3d7ebdeb2c297bd26272384e955033493ca291c.tar.gz blackbird-op-linux-f3d7ebdeb2c297bd26272384e955033493ca291c.zip | |
xfs: fix superblock inprogress check
From inspection, the superblock sb_inprogress check is done in the
verifier and triggered only for the primary superblock via a
"bp->b_bn == XFS_SB_DADDR" check.
Unfortunately, the primary superblock is an uncached buffer, and
hence it is configured by xfs_buf_read_uncached() with:
bp->b_bn = XFS_BUF_DADDR_NULL; /* always null for uncached buffers */
And so this check never triggers. Fix it.
cc: <stable@vger.kernel.org>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/xfs/libxfs/xfs_sb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c index 0e3d4f5ec33c..4aecc5fefe96 100644 --- a/fs/xfs/libxfs/xfs_sb.c +++ b/fs/xfs/libxfs/xfs_sb.c @@ -583,7 +583,8 @@ xfs_sb_verify( * Only check the in progress field for the primary superblock as * mkfs.xfs doesn't clear it from secondary superblocks. */ - return xfs_mount_validate_sb(mp, &sb, bp->b_bn == XFS_SB_DADDR, + return xfs_mount_validate_sb(mp, &sb, + bp->b_maps[0].bm_bn == XFS_SB_DADDR, check_version); } |
