diff options
| author | Trond Myklebust <trondmy@gmail.com> | 2019-11-27 17:05:51 -0500 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2019-11-30 14:55:38 -0500 |
| commit | a25e3726b32c746c0098125d4c7463bb84df72bb (patch) | |
| tree | 7ae7376eae2f736843731a269c3a77f7920317d0 /fs/nfsd/nfs4proc.c | |
| parent | 8729aaba74626c4ebce3abf1b9e96bb62d2958ca (diff) | |
| download | blackbird-op-linux-a25e3726b32c746c0098125d4c7463bb84df72bb.tar.gz blackbird-op-linux-a25e3726b32c746c0098125d4c7463bb84df72bb.zip | |
nfsd: Ensure CLONE persists data and metadata changes to the target file
The NFSv4.2 CLONE operation has implicit persistence requirements on the
target file, since there is no protocol requirement that the client issue
a separate operation to persist data.
For that reason, we should call vfs_fsync_range() on the destination file
after a successful call to vfs_clone_file_range().
Fixes: ffa0160a1039 ("nfsd: implement the NFSv4.2 CLONE operation")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: stable@vger.kernel.org # v4.5+
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfs4proc.c')
| -rw-r--r-- | fs/nfsd/nfs4proc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 4e3e77b76411..38c0aeda500e 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1077,7 +1077,8 @@ nfsd4_clone(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, goto out; status = nfsd4_clone_file_range(src->nf_file, clone->cl_src_pos, - dst->nf_file, clone->cl_dst_pos, clone->cl_count); + dst->nf_file, clone->cl_dst_pos, clone->cl_count, + EX_ISSYNC(cstate->current_fh.fh_export)); nfsd_file_put(dst); nfsd_file_put(src); |
