summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2019-04-16 10:56:08 +0200
committerMichael S. Tsirkin <mst@redhat.com>2019-05-12 13:11:35 -0400
commit889e31e73a738183a402cf4dbca991dce2abce96 (patch)
tree3299686e7c6a28be19a8a39b70e888e40dc8fe55 /drivers
parentd63031bb0fc0314541340f08a0c35c40216ca72a (diff)
downloadblackbird-op-linux-889e31e73a738183a402cf4dbca991dce2abce96.tar.gz
blackbird-op-linux-889e31e73a738183a402cf4dbca991dce2abce96.zip
vhost-scsi: remove incorrect memory barrier
At this point, vs_tpg is not public at all; tv_tpg_vhost_count is accessed under tpg->tv_tpg_mutex; tpg->vhost_scsi is accessed under vhost_scsi_mutex. Therefor there are no atomic operations involved at all here, just remove the barrier. Reported-by: Andrea Parri <andrea.parri@amarulasolutions.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/vhost/scsi.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 618fb6461017..c090d177bd75 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1443,7 +1443,6 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
tpg->tv_tpg_vhost_count++;
tpg->vhost_scsi = vs;
vs_tpg[tpg->tport_tpgt] = tpg;
- smp_mb__after_atomic();
match = true;
}
mutex_unlock(&tpg->tv_tpg_mutex);
OpenPOWER on IntegriCloud