summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2007-01-21 20:46:45 +0100
committerStefan Richter <stefanr@s5r6.in-berlin.de>2007-03-09 22:02:41 +0100
commit6cad95fe97dc062d0367da125ac0b2e5f1694b23 (patch)
tree54f7193d91e44adfb983374acb2128667189eca4 /drivers
parent5af4e5eab30d481f76b89a2167c873dfad960acb (diff)
downloadblackbird-op-linux-6cad95fe97dc062d0367da125ac0b2e5f1694b23.tar.gz
blackbird-op-linux-6cad95fe97dc062d0367da125ac0b2e5f1694b23.zip
firewire: fix failure path in ohci_enable_phys_dma
"goto out" happens with the lock taken. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/firewire/fw-ohci.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/firewire/fw-ohci.c b/drivers/firewire/fw-ohci.c
index ea52e150a8e6..1b4b53d6d925 100644
--- a/drivers/firewire/fw-ohci.c
+++ b/drivers/firewire/fw-ohci.c
@@ -850,10 +850,8 @@ ohci_enable_phys_dma(struct fw_card *card, int node_id, int generation)
1 << (node_id - 32));
}
flush_writes(ohci);
-
- spin_unlock_irqrestore(&ohci->lock, flags);
-
out:
+ spin_unlock_irqrestore(&ohci->lock, flags);
return retval;
}
OpenPOWER on IntegriCloud