summaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2017-08-21 16:49:58 +0200
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2017-08-21 16:49:58 +0200
commit7588f1ecc5f0c914e669d8afb6525f47cd1c4355 (patch)
treefe3caf4cfae7e426c3ac1972e55daccc3a712511 /drivers/video
parent3df3e41c31528e9bae969b3299b35ac672bd27ef (diff)
downloadblackbird-op-linux-7588f1ecc5f0c914e669d8afb6525f47cd1c4355.tar.gz
blackbird-op-linux-7588f1ecc5f0c914e669d8afb6525f47cd1c4355.zip
video: fbdev: pxa3xx_gcu: fix error return code in pxa3xx_gcu_probe()
platform_get_irq() returns an error code, but the pxa3xx_gcu driver ignores it and always returns -ENODEV. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Also, notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print and propagate the return value of platform_get_irq on failure. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/fbdev/pxa3xx-gcu.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 50bce45e7f3d..933619da1a94 100644
--- a/drivers/video/fbdev/pxa3xx-gcu.c
+++ b/drivers/video/fbdev/pxa3xx-gcu.c
@@ -626,8 +626,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
/* request the IRQ */
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "no IRQ defined\n");
- return -ENODEV;
+ dev_err(dev, "no IRQ defined: %d\n", irq);
+ return irq;
}
ret = devm_request_irq(dev, irq, pxa3xx_gcu_handle_irq,
OpenPOWER on IntegriCloud