summaryrefslogtreecommitdiffstats
path: root/drivers/tty/hvc/hvc_console.h
diff options
context:
space:
mode:
authorSam Mendoza-Jonas <sam@mendozajonas.com>2016-07-11 13:38:57 +1000
committerMichael Ellerman <mpe@ellerman.id.au>2016-07-27 12:38:18 +1000
commitbbc3dfe8805de86874b1a1b1429a002e8670043e (patch)
tree5fc55f25dd0daf89975481a3320fb7c24c9f0ecd /drivers/tty/hvc/hvc_console.h
parenta431b946db581d6a121d035a887d370cdc4b8dea (diff)
downloadblackbird-op-linux-bbc3dfe8805de86874b1a1b1429a002e8670043e.tar.gz
blackbird-op-linux-bbc3dfe8805de86874b1a1b1429a002e8670043e.zip
tty/hvc: Use IRQF_SHARED for OPAL hvc consoles
Commit 2def86a7200c ("hvc: Convert to using interrupts instead of opal events") enabled the use of interrupts in the hvc_driver for OPAL platforms. However on machines with more than one hvc console, any console after the first will fail to register an interrupt handler in notifier_add_irq() since all consoles share the same IRQ number but do not set the IRQF_SHARED flag: genirq: Flags mismatch irq 31. 00000000 (hvc_console) vs. 00000000 (hvc_console) hvc_open: request_irq failed with rc -16. This error propagates up to hvc_open() and the console is closed, but OPAL will still generate interrupts that are not handled, leading to rcu_sched stall warnings. Set IRQF_SHARED when calling request_irq(), allowing additional consoles to start properly. This is only set for consoles handled by hvc_opal_probe(), leaving other types unaffected. Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'drivers/tty/hvc/hvc_console.h')
-rw-r--r--drivers/tty/hvc/hvc_console.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/hvc/hvc_console.h b/drivers/tty/hvc/hvc_console.h
index 913101980827..798c48d0d32c 100644
--- a/drivers/tty/hvc/hvc_console.h
+++ b/drivers/tty/hvc/hvc_console.h
@@ -60,6 +60,7 @@ struct hvc_struct {
struct winsize ws;
struct work_struct tty_resize;
struct list_head next;
+ unsigned long flags;
};
/* implemented by a low level driver */
OpenPOWER on IntegriCloud