summaryrefslogtreecommitdiffstats
path: root/drivers/staging/wlan-ng
diff options
context:
space:
mode:
authorPeter Huewe <peterhuewe@gmx.de>2013-02-14 03:37:10 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-02-14 09:26:23 -0800
commitfae7e4d39373305cf505d1f0871a4491897d56f9 (patch)
treea5a470d46528c6d0b9508adcb19eae2bca7a0735 /drivers/staging/wlan-ng
parent0bcc0429bdb9f7cca3b7ab1f905b0d47031c03e0 (diff)
downloadblackbird-op-linux-fae7e4d39373305cf505d1f0871a4491897d56f9.tar.gz
blackbird-op-linux-fae7e4d39373305cf505d1f0871a4491897d56f9.zip
staging/wlan-ng: Fix 'Branch condition evaluates to a garbage value' in p80211netdev.c
clang/scan-build complains that: p80211netdev.c:451:6: warning: Branch condition evaluates to a garbage value if ((p80211_wep.data) && (p80211_wep.data != skb->data)) ^~~~~~~~~~~~~~~~~ This can happen in p80211knetdev_hard_start_xmit if - if (wlandev->state != WLAN_DEVICE_OPEN) evaluates to true. the execution flow then continues at the 'failed' label where p80211_wep.data is used without being initialized first. -> Initialize the data field to NULL to fix this issue. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/wlan-ng')
-rw-r--r--drivers/staging/wlan-ng/p80211netdev.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 750330f064f9..0039e082507d 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -351,6 +351,8 @@ static int p80211knetdev_hard_start_xmit(struct sk_buff *skb,
union p80211_hdr p80211_hdr;
struct p80211_metawep p80211_wep;
+ p80211_wep.data = NULL;
+
if (skb == NULL)
return NETDEV_TX_OK;
OpenPOWER on IntegriCloud