diff options
| author | Cyril Roelandt <tipecaml@gmail.com> | 2012-12-12 01:24:54 +0100 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2012-12-19 15:11:41 +0000 |
| commit | d3601e56cf64a3f2df6f6380cccb3644274406e2 (patch) | |
| tree | 7f7ed6a7c4bbf43bb2abb7be04660aef2a49e279 /drivers/spi | |
| parent | 6a79131318dd6f71ec46e0af1daa581e695fd5ab (diff) | |
| download | blackbird-op-linux-d3601e56cf64a3f2df6f6380cccb3644274406e2.tar.gz blackbird-op-linux-d3601e56cf64a3f2df6f6380cccb3644274406e2.zip | |
spi/sh-hspi: fix return value check in hspi_probe().
According to its documentation, clk_get() returns a "valid IS_ERR() condition
containing errno", so we should call IS_ERR() rather than a NULL check.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-sh-hspi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index 32f7b55fce09..60cfae51c713 100644 --- a/drivers/spi/spi-sh-hspi.c +++ b/drivers/spi/spi-sh-hspi.c @@ -290,7 +290,7 @@ static int hspi_probe(struct platform_device *pdev) } clk = clk_get(NULL, "shyway_clk"); - if (!clk) { + if (IS_ERR(clk)) { dev_err(&pdev->dev, "shyway_clk is required\n"); ret = -EINVAL; goto error0; |
