summaryrefslogtreecommitdiffstats
path: root/drivers/spi/orion_spi.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-09-29 17:31:29 +0900
committerGrant Likely <grant.likely@secretlab.ca>2010-09-29 17:31:29 +0900
commite447d3588e1c5944f607083cb509663f8015d420 (patch)
tree66e90d9ec1e6579f8e014384664791dfeb2d6cca /drivers/spi/orion_spi.c
parent079a176d87a4da4cb18864c54d3932131e11e229 (diff)
downloadblackbird-op-linux-e447d3588e1c5944f607083cb509663f8015d420.tar.gz
blackbird-op-linux-e447d3588e1c5944f607083cb509663f8015d420.zip
spi/orion: Drop unnecessary null test
list_for_each_entry binds its first argument to a non-null value, and thus any null test on the value of that argument is superfluous. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ iterator I; expression x,E; @@ I(x,...) { <... - (x != NULL) && E ...> } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers/spi/orion_spi.c')
-rw-r--r--drivers/spi/orion_spi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/orion_spi.c b/drivers/spi/orion_spi.c
index 3aea50da7b29..0b677dc041ad 100644
--- a/drivers/spi/orion_spi.c
+++ b/drivers/spi/orion_spi.c
@@ -404,7 +404,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m)
goto msg_rejected;
}
- if ((t != NULL) && t->bits_per_word)
+ if (t->bits_per_word)
bits_per_word = t->bits_per_word;
if ((bits_per_word != 8) && (bits_per_word != 16)) {
@@ -415,7 +415,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m)
goto msg_rejected;
}
/*make sure buffer length is even when working in 16 bit mode*/
- if ((t != NULL) && (t->bits_per_word == 16) && (t->len & 1)) {
+ if ((t->bits_per_word == 16) && (t->len & 1)) {
dev_err(&spi->dev,
"message rejected : "
"odd data length (%d) while in 16 bit mode\n",
OpenPOWER on IntegriCloud