summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorNeil Horman <nhorman@tuxdriver.com>2013-10-08 23:43:58 +0000
committerRobert Love <robert.w.love@intel.com>2013-10-14 08:25:40 -0700
commit55d0ac5d2839fe270cea02fad44eed13750a0efd (patch)
treede82cab645bd2ffb205c5fb5de40dc3ac99ccdbc /drivers/scsi
parent9d34876f820d55c94bd0b2a2ed3d2e2976cbd997 (diff)
downloadblackbird-op-linux-55d0ac5d2839fe270cea02fad44eed13750a0efd.tar.gz
blackbird-op-linux-55d0ac5d2839fe270cea02fad44eed13750a0efd.zip
fcoe: Fix missing mutex_unlock in fcoe_sysfs_fcf_add error path
In this pending patch: http://patchwork.open-fcoe.org/patch/104/ Tomas Henzl noted that the error path when fcoe_fcf_device_add fails, was missing a mutex_unlock call. Not sure what staet the integration of the above patch is in, but if you could either merge this with it, or apply it on top of what you already have, that would be great. Thanks! Signed-off-by: Neil Horman <nhorman@tuxdriver.com> CC: thenzl@redhat.com Reported-by: thenzl@redhat.com Signed-off-by: Robert Love <robert.w.love@intel.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/fcoe/fcoe_ctlr.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index 75efdbc54ef8..2aba32f12f13 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -203,6 +203,7 @@ static int fcoe_sysfs_fcf_add(struct fcoe_fcf *new)
fcf_dev = fcoe_fcf_device_add(ctlr_dev, temp);
if (unlikely(!fcf_dev)) {
rc = -ENOMEM;
+ mutex_unlock(&ctlr_dev->lock);
goto out;
}
OpenPOWER on IntegriCloud