summaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/pinctrl-ab8540.c
diff options
context:
space:
mode:
authorLee Jones <lee.jones@linaro.org>2013-01-31 09:45:17 +0000
committerLinus Walleij <linus.walleij@linaro.org>2013-02-06 22:38:40 +0100
commitb9fab6e45d2d41de5495f7d40808e9e131652f92 (patch)
treed832b21acfd75e63982c6031e5b20998febf760a /drivers/pinctrl/pinctrl-ab8540.c
parentfa1ec996ac1a42e46ec7dca089252f124c81d7bd (diff)
downloadblackbird-op-linux-b9fab6e45d2d41de5495f7d40808e9e131652f92.tar.gz
blackbird-op-linux-b9fab6e45d2d41de5495f7d40808e9e131652f92.zip
pinctrl/abx500: align GPIO cluster boundaries
Not quite sure how this ever worked. In ab8500_gpio_to_irq() the GPIO for conversion is passed through as the second argument. If GPIO13, which is a valid GPIO for IRQ functionality, was received; it would be rejected by the following guard: GPIO_IRQ_CLUSTER(5, 12, 0); /* GPIO numbers start from 1 */ if (offset >= cluster->start && offset <= cluster->end) /* Valid GPIO for IRQ use */ Signed-off-by: Lee Jones <lee.jones@linaro.org> [Augmented to account for off-by-one problem] Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-ab8540.c')
-rw-r--r--drivers/pinctrl/pinctrl-ab8540.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c
index e75310de7067..0fcd9431607c 100644
--- a/drivers/pinctrl/pinctrl-ab8540.c
+++ b/drivers/pinctrl/pinctrl-ab8540.c
@@ -377,8 +377,8 @@ static struct pullud ab8540_pullud = {
* GPIO51 to GPIO54
*/
struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
- GPIO_IRQ_CLUSTER(42, 43, 2), /* GPIO numbers start from 1 */
- GPIO_IRQ_CLUSTER(50, 53, 0),
+ GPIO_IRQ_CLUSTER(43, 44, 2),
+ GPIO_IRQ_CLUSTER(51, 54, 0),
};
static struct abx500_pinctrl_soc_data ab8540_soc = {
OpenPOWER on IntegriCloud