summaryrefslogtreecommitdiffstats
path: root/drivers/pci/controller/pci-aardvark.c
diff options
context:
space:
mode:
authorWen Yang <wen.yang99@zte.com.cn>2019-02-27 12:40:39 +0800
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>2019-04-01 10:42:24 +0100
commit69adea738eb2be70b4753dbb60eb1de9abbfb4dc (patch)
tree4220aa0593133c5c11952ccd5e58801c6d3bcd7f /drivers/pci/controller/pci-aardvark.c
parentb35c0e4543945fe9b21e6ed9ab72cdb5efb30718 (diff)
downloadblackbird-op-linux-69adea738eb2be70b4753dbb60eb1de9abbfb4dc.tar.gz
blackbird-op-linux-69adea738eb2be70b4753dbb60eb1de9abbfb4dc.zip
PCI: rockchip: Fix a leaked reference by adding missing of_node_put()
The call to of_get_child_by_name() returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear() also calls of_node_get() to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the following warnings: ./drivers/pci/controller/pcie-rockchip-host.c:729:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 718, but without a corresponding object release within this function. ./drivers/pci/controller/pcie-rockchip-host.c:732:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 718, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Shawn Lin <shawn.lin@rock-chips.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Heiko Stuebner <heiko@sntech.de> Cc: linux-pci@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org
Diffstat (limited to 'drivers/pci/controller/pci-aardvark.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud