summaryrefslogtreecommitdiffstats
path: root/drivers/misc
diff options
context:
space:
mode:
authorVladimir Zapolskiy <vz@mleia.com>2015-07-27 00:18:47 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-08-05 13:53:39 -0700
commit2b6e5ba3d2ed958f6c32bfc84cdab3377e391f02 (patch)
tree9a266e88cfdbca868ef4cd0abadeebebda196fce /drivers/misc
parentacb921a5a1e5fb2b864be25caf7317531f91a832 (diff)
downloadblackbird-op-linux-2b6e5ba3d2ed958f6c32bfc84cdab3377e391f02.tar.gz
blackbird-op-linux-2b6e5ba3d2ed958f6c32bfc84cdab3377e391f02.zip
misc: ds1682: clean up ds1682_eeprom_read() and ds1682_eeprom_write()
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
-rw-r--r--drivers/misc/ds1682.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/drivers/misc/ds1682.c b/drivers/misc/ds1682.c
index b909fb30232a..c7112276a039 100644
--- a/drivers/misc/ds1682.c
+++ b/drivers/misc/ds1682.c
@@ -148,12 +148,6 @@ static ssize_t ds1682_eeprom_read(struct file *filp, struct kobject *kobj,
dev_dbg(&client->dev, "ds1682_eeprom_read(p=%p, off=%lli, c=%zi)\n",
buf, off, count);
- if (off >= DS1682_EEPROM_SIZE)
- return 0;
-
- if (off + count > DS1682_EEPROM_SIZE)
- count = DS1682_EEPROM_SIZE - off;
-
rc = i2c_smbus_read_i2c_block_data(client, DS1682_REG_EEPROM + off,
count, buf);
if (rc < 0)
@@ -171,12 +165,6 @@ static ssize_t ds1682_eeprom_write(struct file *filp, struct kobject *kobj,
dev_dbg(&client->dev, "ds1682_eeprom_write(p=%p, off=%lli, c=%zi)\n",
buf, off, count);
- if (off >= DS1682_EEPROM_SIZE)
- return -ENOSPC;
-
- if (off + count > DS1682_EEPROM_SIZE)
- count = DS1682_EEPROM_SIZE - off;
-
/* Write out to the device */
if (i2c_smbus_write_i2c_block_data(client, DS1682_REG_EEPROM + off,
count, buf) < 0)
OpenPOWER on IntegriCloud