summaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorJoseph Lo <josephl@nvidia.com>2018-04-18 12:24:04 +0200
committerLee Jones <lee.jones@linaro.org>2018-05-29 09:11:12 +0100
commit704800dd3fe6e5bfc52773081acedc62860e508f (patch)
tree26b616b6831d16b80d78b3756d151c68d35a2c91 /drivers/mfd
parentabeed71b645c7e0e75b078e1b6f3db7d6d4404a2 (diff)
downloadblackbird-op-linux-704800dd3fe6e5bfc52773081acedc62860e508f.tar.gz
blackbird-op-linux-704800dd3fe6e5bfc52773081acedc62860e508f.zip
mfd: cros_ec_i2c: Moving the system sleep pm ops to late
The cros_ec_i2c driver is still active after it had suspended or before it resumes. Besides that, it also tried to transfer data even after the I2C host had been suspended. This will lead the system to crash. During the test, we also observe that the EC needs to be resumed earlier due to some status polling from the EC FW (e.g. battery status). So we move the PM ops to late stage to make it work normally. Signed-off-by: Joseph Lo <josephl@nvidia.com> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/cros_ec_i2c.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
index 02a7bacdc056..ef9b4763356f 100644
--- a/drivers/mfd/cros_ec_i2c.c
+++ b/drivers/mfd/cros_ec_i2c.c
@@ -342,8 +342,9 @@ static int cros_ec_i2c_resume(struct device *dev)
}
#endif
-static SIMPLE_DEV_PM_OPS(cros_ec_i2c_pm_ops, cros_ec_i2c_suspend,
- cros_ec_i2c_resume);
+static const struct dev_pm_ops cros_ec_i2c_pm_ops = {
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_i2c_suspend, cros_ec_i2c_resume)
+};
#ifdef CONFIG_OF
static const struct of_device_id cros_ec_i2c_of_match[] = {
OpenPOWER on IntegriCloud