summaryrefslogtreecommitdiffstats
path: root/drivers/mfd/intel_soc_pmic_core.c
diff options
context:
space:
mode:
authorJarkko Nikula <jarkko.nikula@linux.intel.com>2015-02-13 15:01:13 +0200
committerLee Jones <lee.jones@linaro.org>2015-03-03 16:41:11 +0000
commit9c98dcb08c85e67ce83f3a7f8785da20349533fe (patch)
treeb5a8dac3cc903f646a172b96aa88d876cae5be93 /drivers/mfd/intel_soc_pmic_core.c
parent575ef7f6d5df2aec86f407c76c0b95b3064e4b30 (diff)
downloadblackbird-op-linux-9c98dcb08c85e67ce83f3a7f8785da20349533fe.tar.gz
blackbird-op-linux-9c98dcb08c85e67ce83f3a7f8785da20349533fe.zip
mfd: intel_soc_pmic: Move PMIC interrupt comment to probe function
intel_soc_pmic_find_gpio_irq() tries to find a GPIO interrupt but doesn't select between it or I2C interrupt so it makes more sense to move this comment to intel_soc_pmic_i2c_probe() with minor edits. Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/intel_soc_pmic_core.c')
-rw-r--r--drivers/mfd/intel_soc_pmic_core.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
index 80cef048b904..3b41d3d645c6 100644
--- a/drivers/mfd/intel_soc_pmic_core.c
+++ b/drivers/mfd/intel_soc_pmic_core.c
@@ -26,11 +26,6 @@
#include <linux/mfd/intel_soc_pmic.h>
#include "intel_soc_pmic_core.h"
-/*
- * On some boards the PMIC interrupt may come from a GPIO line.
- * Try to lookup the ACPI table and see if such connection exists. If not,
- * return -ENOENT and use the IRQ provided by I2C.
- */
static int intel_soc_pmic_find_gpio_irq(struct device *dev)
{
struct gpio_desc *desc;
@@ -71,6 +66,11 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,
pmic->regmap = devm_regmap_init_i2c(i2c, config->regmap_config);
+ /*
+ * On some boards the PMIC interrupt may come from a GPIO line. Try to
+ * lookup the ACPI table for a such connection and setup a GPIO
+ * interrupt if it exists. Otherwise use the IRQ provided by I2C
+ */
irq = intel_soc_pmic_find_gpio_irq(dev);
pmic->irq = (irq < 0) ? i2c->irq : irq;
OpenPOWER on IntegriCloud