summaryrefslogtreecommitdiffstats
path: root/drivers/media/pci
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@s-opensource.com>2017-05-18 08:55:41 -0300
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-05-19 07:08:05 -0300
commitb7c15d5d90661f6eaa49f7a7a72d482fe1923d4a (patch)
tree3219960fcf4224dd157f7ecf0a78f6530dd9851f /drivers/media/pci
parent17992979f6f3d3c531498e7f37bfdaf28f50848f (diff)
downloadblackbird-op-linux-b7c15d5d90661f6eaa49f7a7a72d482fe1923d4a.tar.gz
blackbird-op-linux-b7c15d5d90661f6eaa49f7a7a72d482fe1923d4a.zip
[media] saa7164: better handle error codes
Right now, the driver is doing the right thing for PVC_ERRORCODE_UNKNOWN and PVC_ERRORCODE_INVALID_CONTROL: for both, it returns an error code (SAA_ERR_NOT_SUPPORTED). However, it is printing two error messages instead of one on those cases. Fix the logic. Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/pci')
-rw-r--r--drivers/media/pci/saa7164/saa7164-cmd.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c
index 175015ca79f2..dfebd77ada59 100644
--- a/drivers/media/pci/saa7164/saa7164-cmd.c
+++ b/drivers/media/pci/saa7164/saa7164-cmd.c
@@ -506,6 +506,8 @@ int saa7164_cmd_send(struct saa7164_dev *dev, u8 id, enum tmComResCmd command,
dprintk(DBGLVL_CMD,
"%s() UNKNOWN OR INVALID CONTROL\n",
__func__);
+ ret = SAA_ERR_NOT_SUPPORTED;
+ break;
default:
dprintk(DBGLVL_CMD, "%s() UNKNOWN\n", __func__);
ret = SAA_ERR_NOT_SUPPORTED;
OpenPOWER on IntegriCloud