summaryrefslogtreecommitdiffstats
path: root/drivers/md/bcache
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-09-03 21:25:44 +0800
committerJens Axboe <axboe@kernel.dk>2019-09-03 08:08:29 -0600
commitd66c9920c0cf984cf99cab5036fd5f3a1b7fba46 (patch)
tree4b94f032bb44096974c8a34a81d65be8af94e0b4 /drivers/md/bcache
parentd55a4ae9e1af5fb1657e38284ef46c56e668efdb (diff)
downloadblackbird-op-linux-d66c9920c0cf984cf99cab5036fd5f3a1b7fba46.tar.gz
blackbird-op-linux-d66c9920c0cf984cf99cab5036fd5f3a1b7fba46.zip
bcache: Fix an error code in bch_dump_read()
The copy_to_user() function returns the number of bytes remaining to be copied, but the intention here was to return -EFAULT if the copy fails. Fixes: cafe56359144 ("bcache: A block layer cache") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Coly Li <colyli@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md/bcache')
-rw-r--r--drivers/md/bcache/debug.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
index 8b123be05254..336f43910383 100644
--- a/drivers/md/bcache/debug.c
+++ b/drivers/md/bcache/debug.c
@@ -178,10 +178,9 @@ static ssize_t bch_dump_read(struct file *file, char __user *buf,
while (size) {
struct keybuf_key *w;
unsigned int bytes = min(i->bytes, size);
- int err = copy_to_user(buf, i->buf, bytes);
- if (err)
- return err;
+ if (copy_to_user(buf, i->buf, bytes))
+ return -EFAULT;
ret += bytes;
buf += bytes;
OpenPOWER on IntegriCloud