diff options
| author | Dmitry Torokhov <dtor@chromium.org> | 2014-11-14 14:16:42 -0800 |
|---|---|---|
| committer | Jason Cooper <jason@lakedaemon.net> | 2014-11-26 06:28:42 +0000 |
| commit | d99ba4465a08138966083d6c256b2f66e85a5095 (patch) | |
| tree | 5cd8b1c5964675179bb487c26cb4b50f06e868cd /drivers/irqchip | |
| parent | 714710e1a2f6528be83d0f1c6cdf1e79a676d234 (diff) | |
| download | blackbird-op-linux-d99ba4465a08138966083d6c256b2f66e85a5095.tar.gz blackbird-op-linux-d99ba4465a08138966083d6c256b2f66e85a5095.zip | |
irqchip: brcmstb-l2: Fix error handling of irq_of_parse_and_map
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Kevin Cernekee <cernekee@gmail.com>
Link: https://lkml.kernel.org/r/20141114221642.GA37468@dtor-ws
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-brcmstb-l2.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c index c15c840987d2..14691a4cb84c 100644 --- a/drivers/irqchip/irq-brcmstb-l2.c +++ b/drivers/irqchip/irq-brcmstb-l2.c @@ -135,9 +135,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np, __raw_writel(0xffffffff, data->base + CPU_CLEAR); data->parent_irq = irq_of_parse_and_map(np, 0); - if (data->parent_irq < 0) { + if (!data->parent_irq) { pr_err("failed to find parent interrupt\n"); - ret = data->parent_irq; + ret = -EINVAL; goto out_unmap; } |
