summaryrefslogtreecommitdiffstats
path: root/drivers/iio/temperature
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-10-25 17:55:04 +0200
committerJonathan Cameron <jic23@kernel.org>2016-10-25 17:28:23 +0100
commit32cb7d27e65df9daa7cee8f1fdf7b259f214bee2 (patch)
treef2556630222b5ed71c61d5c2aea98d2800cebfab /drivers/iio/temperature
parent3089ec2c104ccfb7295d6c2a25d5b505cc59669b (diff)
downloadblackbird-op-linux-32cb7d27e65df9daa7cee8f1fdf7b259f214bee2.tar.gz
blackbird-op-linux-32cb7d27e65df9daa7cee8f1fdf7b259f214bee2.zip
iio: maxim_thermocouple: detect invalid storage size in read()
As found by gcc -Wmaybe-uninitialized, having a storage_bytes value other than 2 or 4 will result in undefined behavior: drivers/iio/temperature/maxim_thermocouple.c: In function 'maxim_thermocouple_read': drivers/iio/temperature/maxim_thermocouple.c:141:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] This probably cannot happen, but returning -EINVAL here is appropriate and makes gcc happy and the code more robust. Fixes: 231147ee77f3 ("iio: maxim_thermocouple: Align 16 bit big endian value of raw reads") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/temperature')
-rw-r--r--drivers/iio/temperature/maxim_thermocouple.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
index 39dd2026ccc9..d19a4dea4c3c 100644
--- a/drivers/iio/temperature/maxim_thermocouple.c
+++ b/drivers/iio/temperature/maxim_thermocouple.c
@@ -137,6 +137,8 @@ static int maxim_thermocouple_read(struct maxim_thermocouple_data *data,
case 4:
*val = be32_to_cpu(buf);
break;
+ default:
+ ret = -EINVAL;
}
/* check to be sure this is a valid reading */
OpenPOWER on IntegriCloud