summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
diff options
context:
space:
mode:
authorDeepak Rawat <drawat@vmware.com>2018-06-20 11:23:55 +0200
committerThomas Hellstrom <thellstrom@vmware.com>2018-07-03 20:38:24 +0200
commit7e14eabca82ec75da5200769989d396da46033ee (patch)
tree22eb715f023fb4c09a423dacfdf30184e34aea62 /drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
parent5e24133ea3dfb89fd0cf28cd7a845b66fa680b69 (diff)
downloadblackbird-op-linux-7e14eabca82ec75da5200769989d396da46033ee.tar.gz
blackbird-op-linux-7e14eabca82ec75da5200769989d396da46033ee.zip
drm/vmwgfx: Perform memory validations only when need full modeset.
For cases when full modeset is not requested like page-flip, skip memory validation as the topology is not changed. Signed-off-by: Deepak Rawat <drawat@vmware.com> Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Diffstat (limited to 'drivers/gpu/drm/vmwgfx/vmwgfx_kms.c')
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_kms.c23
1 files changed, 21 insertions, 2 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 387bb39de839..3605ac1702c2 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -1670,13 +1670,32 @@ static int
vmw_kms_atomic_check_modeset(struct drm_device *dev,
struct drm_atomic_state *state)
{
- int ret;
+ struct drm_crtc *crtc;
+ struct drm_crtc_state *crtc_state;
+ bool need_modeset = false;
+ int i, ret;
ret = drm_atomic_helper_check(dev, state);
if (ret)
return ret;
- return vmw_kms_check_topology(dev, state);
+ if (!state->allow_modeset)
+ return ret;
+
+ /*
+ * Legacy path do not set allow_modeset properly like
+ * @drm_atomic_helper_update_plane, This will result in unnecessary call
+ * to vmw_kms_check_topology. So extra set of check.
+ */
+ for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
+ if (drm_atomic_crtc_needs_modeset(crtc_state))
+ need_modeset = true;
+ }
+
+ if (need_modeset)
+ return vmw_kms_check_topology(dev, state);
+
+ return ret;
}
static const struct drm_mode_config_funcs vmw_kms_funcs = {
OpenPOWER on IntegriCloud