summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2014-11-25 23:50:05 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-11-27 15:39:11 +0100
commitabd69c55dd8f1f71b33b8c6165217f4329db8f25 (patch)
tree7a3af2b73d2b9ccf4f625de8f4ade7c16115bda4 /drivers/gpu/drm/amd
parent933f622fc25c7d14f8d435357f9146cfe58a5d7a (diff)
downloadblackbird-op-linux-abd69c55dd8f1f71b33b8c6165217f4329db8f25.tar.gz
blackbird-op-linux-abd69c55dd8f1f71b33b8c6165217f4329db8f25.zip
drm: Handle atomic state properly in kms getfoo ioctl
So the problem with async commit (especially async modeset commit) is that the legacy pointers only get updated after the point of no return, in the async part of the modeset sequence. At least as implemented by the current helper functions. This is done in the set_routing_links function in drm_atomic_helper.c. Which also means that access isn't protected by locks but only coordinated by synchronizing with async workers. No problem thus far, until we lock at the getconnector/encoder ioctls. So fix this up by adding special cases for atomic drivers: For those we need to look at state objects. Unfortunately digging out the correct encoder->crtc link is a bit of work, so wrap this up in a helper function. Moving the assignments of connector->encoder and encoder->crtc earlier isn't a good idea because the point of the atomic helpers is that we stage the state updates. That way the disable functions can still inspect the links and rely upon them. v2: Extract full encoder->crtc lookup into helper (Rob). v3: Extract drm_connector_get_encoder too since - we need to always return state->best_encoder when there is a state otherwise we might return stale data if there's a pending async disable (and chase unlocked pointers, too). Same issue with encoder_get_crtc but there it's a bit more tricky to handle. Cc: Rob Clark <robdclark@gmail.com> Cc: Sean Paul <seanpaul@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> Lightly-Tested-by: Sean Paul <seanpaul@chromium.org> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'drivers/gpu/drm/amd')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud