diff options
| author | Tony Luck <tony.luck@intel.com> | 2011-08-02 15:08:30 -0700 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2011-08-02 15:08:30 -0700 |
| commit | b728a5c806fb36f9adebf2a862bbd015e074afca (patch) | |
| tree | 73de9c81a3265d3977431dee9feb29b037b99a99 /drivers/firmware | |
| parent | 7644c16c7e7431fa398e834109dbb76dc1b51617 (diff) | |
| download | blackbird-op-linux-b728a5c806fb36f9adebf2a862bbd015e074afca.tar.gz blackbird-op-linux-b728a5c806fb36f9adebf2a862bbd015e074afca.zip | |
efivars: fix warnings when CONFIG_PSTORE=n
drivers/firmware/efivars.c:161: warning: ‘utf16_strlen’ defined but not used
utf16_strlen() is only used inside CONFIG_PSTORE - make this "static inline"
to shut the compiler up [thanks to hpa for the suggestion].
drivers/firmware/efivars.c:602: warning: initialization from incompatible pointer type
Between v1 and v2 of this patch series we decided to make the "part" number
unsigned - but missed fixing the stub version of efi_pstore_write()
Acked-by: Matthew Garrett <mjg@redhat.com>
Acked-by: Mike Waychison <mikew@google.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/efivars.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index eacb05e6cfb3..eb80b549ed8d 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -157,7 +157,7 @@ utf16_strnlen(efi_char16_t *s, size_t maxlength) return length; } -static unsigned long +static inline unsigned long utf16_strlen(efi_char16_t *s) { return utf16_strnlen(s, ~0UL); @@ -580,8 +580,8 @@ static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type, return -1; } -static u64 efi_pstore_write(enum pstore_type_id type, int part, size_t size, - struct pstore_info *psi) +static u64 efi_pstore_write(enum pstore_type_id type, unsigned int part, + size_t size, struct pstore_info *psi) { return 0; } |
