summaryrefslogtreecommitdiffstats
path: root/drivers/extcon
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2016-12-03 16:56:49 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-01-11 09:11:39 +0100
commit5b11ebedd6a8bb4271b796e498cd15c0fe1133b6 (patch)
treec0b0c61921982c62c49ec4824616a646409237dd /drivers/extcon
parent488debb9971bc7d0edd6d8080ba78ca02a04f6c4 (diff)
downloadblackbird-op-linux-5b11ebedd6a8bb4271b796e498cd15c0fe1133b6.tar.gz
blackbird-op-linux-5b11ebedd6a8bb4271b796e498cd15c0fe1133b6.zip
extcon: return error code on failure
Function get_zeroed_page() returns a NULL pointer if there is no enough memory. In function extcon_sync(), it returns 0 if the call to get_zeroed_page() fails. The return value 0 indicates success in the context, which is incosistent with the execution status. This patch fixes the bug by returning -ENOMEM. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188611 Signed-off-by: Pan Bian <bianpan2016@163.com> Fixes: a580982f0836e Cc: stable <stable@vger.kernel.org> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/extcon')
-rw-r--r--drivers/extcon/extcon.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 78298460d168..7c1e3a7b14e0 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id)
dev_err(&edev->dev, "out of memory in extcon_set_state\n");
kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE);
- return 0;
+ return -ENOMEM;
}
length = name_show(&edev->dev, NULL, prop_buf);
OpenPOWER on IntegriCloud