summaryrefslogtreecommitdiffstats
path: root/drivers/cpufreq
diff options
context:
space:
mode:
authorXie Yisheng <xieyisheng1@huawei.com>2018-05-31 19:11:15 +0800
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2018-07-02 11:25:40 +0200
commit1111b7836c80ec4094318e1dfb3a5abe6df95afb (patch)
treee814b5d549bf4f61f5b04c9809f14a8541f90370 /drivers/cpufreq
parent021c91791a5e7e85c567452f1be3e4c2c6cb6063 (diff)
downloadblackbird-op-linux-1111b7836c80ec4094318e1dfb3a5abe6df95afb.tar.gz
blackbird-op-linux-1111b7836c80ec4094318e1dfb3a5abe6df95afb.zip
cpufreq: intel_pstate: use match_string() helper
match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq')
-rw-r--r--drivers/cpufreq/intel_pstate.c15
1 files changed, 6 insertions, 9 deletions
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index ece120da3353..a5c368425e36 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -657,21 +657,18 @@ static ssize_t store_energy_performance_preference(
{
struct cpudata *cpu_data = all_cpu_data[policy->cpu];
char str_preference[21];
- int ret, i = 0;
+ int ret;
ret = sscanf(buf, "%20s", str_preference);
if (ret != 1)
return -EINVAL;
- while (energy_perf_strings[i] != NULL) {
- if (!strcmp(str_preference, energy_perf_strings[i])) {
- intel_pstate_set_energy_pref_index(cpu_data, i);
- return count;
- }
- ++i;
- }
+ ret = match_string(energy_perf_strings, -1, str_preference);
+ if (ret < 0)
+ return ret;
- return -EINVAL;
+ intel_pstate_set_energy_pref_index(cpu_data, ret);
+ return count;
}
static ssize_t show_energy_performance_preference(
OpenPOWER on IntegriCloud