diff options
| author | Chengguang Xu <cgxu519@gmx.com> | 2018-12-16 17:35:00 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-12-16 09:01:38 -0700 |
| commit | 38a3499f6d0cb15bd673e517b0656807e22bfd24 (patch) | |
| tree | c28a1a6e770c04dc8e22c5567594ded4fdfe94a1 /drivers/block | |
| parent | e7cc005fef03d2b13246d800e497418d570ad6da (diff) | |
| download | blackbird-op-linux-38a3499f6d0cb15bd673e517b0656807e22bfd24.tar.gz blackbird-op-linux-38a3499f6d0cb15bd673e517b0656807e22bfd24.zip | |
block: loop: check error using IS_ERR instead of IS_ERR_OR_NULL in loop_add()
blk_mq_init_queue() will not return NULL pointer to its caller,
so it's better to replace IS_ERR_OR_NULL using IS_ERR in loop_add().
If in the future things change to check NULL pointer inside loop_add(),
we should return -ENOMEM as return code instead of PTR_ERR(NULL).
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/loop.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 0770004616de..0939f36548c9 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1915,7 +1915,7 @@ static int loop_add(struct loop_device **l, int i) goto out_free_idr; lo->lo_queue = blk_mq_init_queue(&lo->tag_set); - if (IS_ERR_OR_NULL(lo->lo_queue)) { + if (IS_ERR(lo->lo_queue)) { err = PTR_ERR(lo->lo_queue); goto out_cleanup_tags; } |
