summaryrefslogtreecommitdiffstats
path: root/drivers/atm/nicstar.c
diff options
context:
space:
mode:
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>2015-06-25 18:02:29 -0400
committerSteven Rostedt <rostedt@goodmis.org>2015-06-25 18:02:29 -0400
commitb4875bbe7e68f139bd3383828ae8e994a0df6d28 (patch)
tree8f0447111b6a91b8f3c8d33ee89d4120312c7955 /drivers/atm/nicstar.c
parent2cf30dc180cea808077f003c5116388183e54f9e (diff)
downloadblackbird-op-linux-b4875bbe7e68f139bd3383828ae8e994a0df6d28.tar.gz
blackbird-op-linux-b4875bbe7e68f139bd3383828ae8e994a0df6d28.zip
tracing/filter: Do not WARN on operand count going below zero
When testing the fix for the trace filter, I could not come up with a scenario where the operand count goes below zero, so I added a WARN_ON_ONCE(cnt < 0) to the logic. But there is legitimate case that it can happen (although the filter would be wrong). # echo '>' > /sys/kernel/debug/events/ext4/ext4_truncate_exit/filter That is, a single operation without any operands will hit the path where the WARN_ON_ONCE() can trigger. Although this is harmless, and the filter is reported as a error. But instead of spitting out a warning to the kernel dmesg, just fail nicely and report it via the proper channels. Link: http://lkml.kernel.org/r/558C6082.90608@oracle.com Reported-by: Vince Weaver <vincent.weaver@maine.edu> Reported-by: Sasha Levin <sasha.levin@oracle.com> Cc: stable@vger.kernel.org # 2.6.33+ Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'drivers/atm/nicstar.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud