summaryrefslogtreecommitdiffstats
path: root/block/bfq-wf2q.c
diff options
context:
space:
mode:
authorJulian Wiedmann <jwi@linux.ibm.com>2018-11-02 19:04:09 +0100
committerDavid S. Miller <davem@davemloft.net>2018-11-03 10:44:05 -0700
commitbd74a7f9cc033cf4d405788f80292268987dc0c5 (patch)
tree984cb28097df6382fc27a0df7eb2d7e404f3f89c /block/bfq-wf2q.c
parente19e5be8b4cafa8b3f8b0cd1b1dfe20fa0145b83 (diff)
downloadblackbird-op-linux-bd74a7f9cc033cf4d405788f80292268987dc0c5.tar.gz
blackbird-op-linux-bd74a7f9cc033cf4d405788f80292268987dc0c5.zip
s390/qeth: fix HiperSockets sniffer
Sniffing mode for L3 HiperSockets requires that no IP addresses are registered with the HW. The preferred way to achieve this is for userspace to delete all the IPs on the interface. But qeth is expected to also tolerate a configuration where that is not the case, by skipping the IP registration when in sniffer mode. Since commit 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback") reworked the IP registration logic in the L3 subdriver, this no longer works. When the qeth device is set online, qeth_l3_recover_ip() now unconditionally registers all unicast addresses from our internal IP table. While we could fix this particular problem by skipping qeth_l3_recover_ip() on a sniffer device, the more future-proof change is to skip the IP address registration at the lowest level. This way we a) catch any future code path that attempts to register an IP address without considering the sniffer scenario, and b) continue to build up our internal IP table, so that if sniffer mode is switched off later we can operate just like normal. Fixes: 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback") Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'block/bfq-wf2q.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud