diff options
author | Michael Ellerman <michael@ellerman.id.au> | 2005-06-09 12:36:33 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-09 15:39:52 -0700 |
commit | 243cd55e021baf28babdd88112ac03ae5cd4bb9c (patch) | |
tree | f1bf0f1f17ed03f92f0bbce12b3f958dde028906 /arch | |
parent | 7fbdf1a23be1837b8bc5bcec096015ca99e00aa7 (diff) | |
download | blackbird-op-linux-243cd55e021baf28babdd88112ac03ae5cd4bb9c.tar.gz blackbird-op-linux-243cd55e021baf28babdd88112ac03ae5cd4bb9c.zip |
[PATCH] iseries_veth: Supress spurious WARN_ON() at module unload
My patch from a few weeks back (now in mainline), called "Cleanup skbs to
prevent unregister_netdevice() hanging", can cause our TX timeout code to
fire on machines with lots of VLANs (because it takes > 2 seconds between
when we stop the queues and when we're finished stopping the connections).
When that happens the TX timeout code freaks out and does a WARN_ON()
because as far as it's concerned there shouldn't be a TX timeout happening,
which is fair enough.
I have a "proper" fix for this, which is to a) do refcounting on
connections and b) implement a proper ack timer so we don't keep unacked
skbs lying around for ever. But for 2.6.12 I propose just supressing the
WARN_ON(). Users will still see the "NETDEV WATCHDOG" warning, but that's
not nearly as bad as a WARN_ON() which users interpret as an Oops.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions