diff options
author | Andi Kleen <ak@suse.de> | 2008-01-30 13:33:16 +0100 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 13:33:16 +0100 |
commit | 0c07ee38c9d4eb081758f5ad14bbffa7197e1aec (patch) | |
tree | f32f5dba9b03b9fa5ac262a2c569b43ae9d0994e /arch/x86/kernel/setup_64.c | |
parent | 30d432dfab2bcfd021d352e2058fae6b9405caeb (diff) | |
download | blackbird-op-linux-0c07ee38c9d4eb081758f5ad14bbffa7197e1aec.tar.gz blackbird-op-linux-0c07ee38c9d4eb081758f5ad14bbffa7197e1aec.zip |
x86: use the correct cpuid method to detect MWAIT support for C states
Previously there was a AMD specific quirk to handle the case of
AMD Fam10h MWAIT not supporting any C states. But it turns out
that CPUID already has ways to detectly detect that without
using special quirks.
The new code simply checks if MWAIT supports at least C1 and doesn't
use it if it doesn't. No more vendor specific code.
Note this is does not simply clear MWAIT because MWAIT can be still
useful even without C states.
Credit goes to Ben Serebrin for pointing out the (nearly) obvious.
Cc: "Andreas Herrmann" <andreas.herrmann3@amd.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/kernel/setup_64.c')
-rw-r--r-- | arch/x86/kernel/setup_64.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c index 71a420c7fee7..4a3f00b49236 100644 --- a/arch/x86/kernel/setup_64.c +++ b/arch/x86/kernel/setup_64.c @@ -761,10 +761,6 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c) /* MFENCE stops RDTSC speculation */ set_cpu_cap(c, X86_FEATURE_MFENCE_RDTSC); - /* Family 10 doesn't support C states in MWAIT so don't use it */ - if (c->x86 == 0x10 && !force_mwait) - clear_cpu_cap(c, X86_FEATURE_MWAIT); - if (amd_apic_timer_broken()) disable_apic_timer = 1; } |