diff options
author | Julia Lawall <julia@diku.dk> | 2008-11-25 14:13:03 +0100 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-11-25 15:56:03 +0100 |
commit | eff79aee91dd07e944df65fa448c8baeee7709d8 (patch) | |
tree | b1b909864df7e5ac737b685ebe016dd9c771bbe2 /arch/x86/kernel/pci-calgary_64.c | |
parent | 5cf02b7bafddb6c3c16ddfb23d3ce187f70528ba (diff) | |
download | blackbird-op-linux-eff79aee91dd07e944df65fa448c8baeee7709d8.tar.gz blackbird-op-linux-eff79aee91dd07e944df65fa448c8baeee7709d8.zip |
arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple_strtoul
Impact: fix theoretical option string parsing overflow
Since bridge is unsigned, it would seem better to use simple_strtoul that
simple_strtol.
A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r2@
long e;
position p;
@@
e = simple_strtol@p(...)
@@
position p != r2.p;
type T;
T e;
@@
e =
- simple_strtol@p
+ simple_strtoul
(...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: muli@il.ibm.com
Cc: jdmason@kudzu.us
Cc: discuss@x86-64.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/pci-calgary_64.c')
-rw-r--r-- | arch/x86/kernel/pci-calgary_64.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c index e1e731d78f38..d28bbdc35e4e 100644 --- a/arch/x86/kernel/pci-calgary_64.c +++ b/arch/x86/kernel/pci-calgary_64.c @@ -1567,7 +1567,7 @@ static int __init calgary_parse_options(char *p) ++p; if (*p == '\0') break; - bridge = simple_strtol(p, &endp, 0); + bridge = simple_strtoul(p, &endp, 0); if (p == endp) break; |