diff options
author | Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> | 2014-12-15 20:20:31 +0530 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2015-01-23 14:02:51 +1100 |
commit | bf794bf52a80c6278a028f0af2ca32d7c3508c9b (patch) | |
tree | 99156d7b3fa258a370e097cfe0a2ae04cd67616d /arch/powerpc/sysdev/mpic.c | |
parent | 10ea834364c8670b3bf9bbbf6b9d27b4d2ebc9de (diff) | |
download | blackbird-op-linux-bf794bf52a80c6278a028f0af2ca32d7c3508c9b.tar.gz blackbird-op-linux-bf794bf52a80c6278a028f0af2ca32d7c3508c9b.zip |
powerpc/kprobes: Fix kallsyms lookup across powerpc ABIv1 and ABIv2
Currently, all non-dot symbols are being treated as function descriptors
in ABIv1. This is incorrect and is resulting in perf probe not working:
# perf probe do_fork
Added new event:
Failed to write event: Invalid argument
Error: Failed to add events.
# dmesg | tail -1
[192268.073063] Could not insert probe at _text+768432: -22
perf probe bases all kernel probes on _text and writes,
for example, "p:probe/do_fork _text+768432" to
/sys/kernel/debug/tracing/kprobe_events. In-kernel, _text is being
considered to be a function descriptor and is resulting in the above
error.
Fix this by changing how we lookup symbol addresses on ppc64. We first
check for the dot variant of a symbol and look at the non-dot variant
only if that fails. In this manner, we avoid having to look at the
function descriptor.
While at it, also separate out how this works on ABIv2 where
we don't have dot symbols, but need to use the local entry point.
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/sysdev/mpic.c')
0 files changed, 0 insertions, 0 deletions