diff options
author | Roel Kluin <roel.kluin@gmail.com> | 2009-06-04 19:57:24 -0400 |
---|---|---|
committer | Mike Frysinger <vapier@gentoo.org> | 2009-06-12 06:12:07 -0400 |
commit | 0a990614264f04879d9608da1cfcf9a6596efe08 (patch) | |
tree | e4f10199fd1ab998b479fd3395a86b55d68b874d /arch/blackfin/kernel | |
parent | 11aca0e7352b6a28193221cd2dd85f758fb71b23 (diff) | |
download | blackbird-op-linux-0a990614264f04879d9608da1cfcf9a6596efe08.tar.gz blackbird-op-linux-0a990614264f04879d9608da1cfcf9a6596efe08.zip |
Blackfin: fix length checking in kgdb_ebin2mem
The kgdb_ebin2mem() was decrementing the count variable to do parsing, but
then later still tries to use it based on its original meaning. So leave
it untouched and use a different variable to walk the memory.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'arch/blackfin/kernel')
-rw-r--r-- | arch/blackfin/kernel/kgdb.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/arch/blackfin/kernel/kgdb.c b/arch/blackfin/kernel/kgdb.c index c5362b2b9ed1..da28f796ad78 100644 --- a/arch/blackfin/kernel/kgdb.c +++ b/arch/blackfin/kernel/kgdb.c @@ -587,19 +587,18 @@ int kgdb_ebin2mem(char *buf, char *mem, int count) unsigned short *mmr16; unsigned long *mmr32; int err; - int size = 0; + int size; int cpu = raw_smp_processor_id(); tmp_old = tmp_new = buf; - while (count-- > 0) { + for (size = 0; size < count; ++size) { if (*tmp_old == 0x7d) *tmp_new = *(++tmp_old) ^ 0x20; else *tmp_new = *tmp_old; tmp_new++; tmp_old++; - size++; } err = validate_memory_access_address((unsigned long)mem, size); |