summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2016-06-02 10:42:11 +0200
committerTakashi Iwai <tiwai@suse.de>2016-06-02 10:42:11 +0200
commitfabc16fe9a92709c284325fbd14805fa410dc1d3 (patch)
treebe112a29eeb8c1467cc41cd5288d78e6278b9a83
parent1524c7191be24288ac097c7c3c1bc411f36c1fa4 (diff)
downloadblackbird-op-linux-fabc16fe9a92709c284325fbd14805fa410dc1d3.tar.gz
blackbird-op-linux-fabc16fe9a92709c284325fbd14805fa410dc1d3.zip
ALSA: hda - Turn off loopback mixing as default
So far, we enabled the loopback mixing control as default, as this behavior made somewhat compatible with the earlier HD-audio drivers for Realtek & co. However, it's getting annoying as we've got more and more bug reports about the noise coming from the loopback route. Since the loopback mixing is used fairly rarely and often harmful (e.g. using PA), let's get rid of the default turn-on lines. Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/hda/hda_generic.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 320445f3bf73..7e785487c67b 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -2492,10 +2492,6 @@ static int create_loopback_mixing_ctl(struct hda_codec *codec)
if (!snd_hda_gen_add_kctl(spec, NULL, &loopback_mixing_enum))
return -ENOMEM;
spec->have_aamix_ctl = 1;
- /* if no explicit aamix path is present (e.g. for Realtek codecs),
- * enable aamix as default -- just for compatibility
- */
- spec->aamix_mode = !has_aamix_out_paths(spec);
return 0;
}
OpenPOWER on IntegriCloud