diff options
| author | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-06 14:42:57 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-06 14:42:57 -0800 |
| commit | f9e9dcb38f5106fa8cdac04a9e967d5487f1cd20 (patch) | |
| tree | 8d1cbf17b9b54eacde5a7bf7adf4d5ba6cb119dc | |
| parent | 16afea0255cf6963eb924d4334cdb5acb9074581 (diff) | |
| download | blackbird-op-linux-f9e9dcb38f5106fa8cdac04a9e967d5487f1cd20.tar.gz blackbird-op-linux-f9e9dcb38f5106fa8cdac04a9e967d5487f1cd20.zip | |
x86[-64]:Remove 'volatile' from atomic_t
Any code that relies on the volatile would be a bug waiting to happen
anyway.
Don't encourage people to think that putting 'volatile' on data
structures somehow fixes problems. We should always use proper locking
(and other serialization) techniques.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | include/asm-i386/atomic.h | 2 | ||||
| -rw-r--r-- | include/asm-x86_64/atomic.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/include/asm-i386/atomic.h b/include/asm-i386/atomic.h index 51a166242522..a6c024e2506f 100644 --- a/include/asm-i386/atomic.h +++ b/include/asm-i386/atomic.h @@ -14,7 +14,7 @@ * on us. We need to use _exactly_ the address the user gave us, * not some alias that contains the same information. */ -typedef struct { volatile int counter; } atomic_t; +typedef struct { int counter; } atomic_t; #define ATOMIC_INIT(i) { (i) } diff --git a/include/asm-x86_64/atomic.h b/include/asm-x86_64/atomic.h index 007e88d6d43f..93849f7abc24 100644 --- a/include/asm-x86_64/atomic.h +++ b/include/asm-x86_64/atomic.h @@ -21,7 +21,7 @@ * on us. We need to use _exactly_ the address the user gave us, * not some alias that contains the same information. */ -typedef struct { volatile int counter; } atomic_t; +typedef struct { int counter; } atomic_t; #define ATOMIC_INIT(i) { (i) } |
