summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@stericsson.com>2012-11-22 18:50:06 +0100
committerLee Jones <lee.jones@linaro.org>2013-03-07 12:29:20 +0800
commiteb1f95872a053c5aed3e3d13234f8f68e3b2a55a (patch)
tree3398e2a4898bc06c3557fd8a0c0fa54beba2a372
parent9ee17676a5a36621db020c596e766fec24aae959 (diff)
downloadblackbird-op-linux-eb1f95872a053c5aed3e3d13234f8f68e3b2a55a.tar.gz
blackbird-op-linux-eb1f95872a053c5aed3e3d13234f8f68e3b2a55a.zip
mfd: ab8500-debug: Add explicit dependencies
As I am working on SPARSE_IRQ a number of implicit resource grabs in the kernel become evident. For example, some includes like <linux/irqs.h> would implicitly include <mach/irqs.h> and then from there <mach/db8500-regs.h>. In many cases it is masking the fact that drivers do not properly use resources to pass their dependencies, base addresses etc. So write explicit #include statements with TODO items to have this fixed the proper way to all drivers doing this. Signed-off-by: Linus Walleij <linus.walleij@stericsson.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Philippe LANGLAIS <philippe.langlais@stericsson.com> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
-rw-r--r--drivers/mfd/ab8500-debugfs.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 862dbfeb619e..810ac6faabba 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -91,6 +91,9 @@
#include <linux/ctype.h>
#endif
+/* TODO: this file should not reference IRQ_DB8500_AB8500! */
+#include <mach/irqs.h>
+
static u32 debug_bank;
static u32 debug_address;
OpenPOWER on IntegriCloud