diff options
| author | Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> | 2015-11-17 22:35:41 +0800 |
|---|---|---|
| committer | Shuah Khan <shuahkh@osg.samsung.com> | 2015-11-23 13:20:10 -0700 |
| commit | d3edeb47d886cf38bcf0e96c38f15f6cfda67e02 (patch) | |
| tree | 247c560acac523f02d9ffa06fd388b15f79f8437 | |
| parent | 8005c49d9aea74d382f474ce11afbbc7d7130bec (diff) | |
| download | blackbird-op-linux-d3edeb47d886cf38bcf0e96c38f15f6cfda67e02.tar.gz blackbird-op-linux-d3edeb47d886cf38bcf0e96c38f15f6cfda67e02.zip | |
selftests/capabilities: clean up for Makefile
Clean up the following things:
1. Avoid the broken when use TARGETS in the command line, eg:
$ make -C tools/testing/selftests TARGETS=capabilities
make[1]: *** No rule to make target 'capabilities', needed by 'all'. Stop.
Replace TARGETS with BINARIES.
2. User need to provide cap-ng.h and libcap-ng.so for cross compiling.
Replace ':=' with '+=' for CFLAGS and introduce LDLIBS to archieve
it. Delete useless EXTRA_CLAGS at the same time.
3. Delete the duplicated definition which is already defined by
lib.mk.
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
| -rw-r--r-- | tools/testing/selftests/capabilities/Makefile | 21 |
1 files changed, 9 insertions, 12 deletions
diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile index 8c8f0c1f0889..008602aed920 100644 --- a/tools/testing/selftests/capabilities/Makefile +++ b/tools/testing/selftests/capabilities/Makefile @@ -1,18 +1,15 @@ -all: - -include ../lib.mk - -.PHONY: all clean - -TARGETS := validate_cap test_execve +TEST_FILES := validate_cap TEST_PROGS := test_execve -CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng +BINARIES := $(TEST_FILES) $(TEST_PROGS) -all: $(TARGETS) +CFLAGS += -O2 -g -std=gnu99 -Wall +LDLIBS += -lcap-ng -lrt -ldl + +all: $(BINARIES) clean: - $(RM) $(TARGETS) + $(RM) $(BINARIES) + +include ../lib.mk -$(TARGETS): %: %.c - $(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl |
