summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMattia Dongili <malattia@linux.it>2009-04-12 11:26:30 +0000
committerLen Brown <len.brown@intel.com>2009-04-23 23:57:34 -0400
commitc35d4b3532ed3e2076fb14c25385cf6cef41cc69 (patch)
tree958a8409fc348a48ac9185981c5b66bde6e53897
parent5aa63f038f042fd1acd6e720a95df72857db0bc7 (diff)
downloadblackbird-op-linux-c35d4b3532ed3e2076fb14c25385cf6cef41cc69.tar.gz
blackbird-op-linux-c35d4b3532ed3e2076fb14c25385cf6cef41cc69.zip
sony-laptop: fix bogus error message display on resume
sony_backlight_update_status returns 0 on success -1 on failure (i.e.: the return value from acpi_callsetfunc. The return value in the resume path was broken and thus always displaying a bogus warning about not being able to restore the brightness level. Signed-off-by: Mattia Dongili <malattia@linux.it> Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r--drivers/platform/x86/sony-laptop.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 3541ca097d09..d93cff656c99 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -1041,7 +1041,7 @@ static int sony_nc_resume(struct acpi_device *device)
/* set the last requested brightness level */
if (sony_backlight_device &&
- !sony_backlight_update_status(sony_backlight_device))
+ sony_backlight_update_status(sony_backlight_device) < 0)
printk(KERN_WARNING DRV_PFX "unable to restore brightness level\n");
return 0;
OpenPOWER on IntegriCloud