summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJinshan Xiong <jinshan.xiong@intel.com>2015-02-01 21:52:07 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-02-07 17:31:10 +0800
commitc2fcdf6c427c9c2e305320d6ee82a8ca9f4fa961 (patch)
tree08fd0349f9b66677d3587779f92ed324e937e9b3
parentaf3fa7c71bf61a4ff8e9203860c24795183f9da4 (diff)
downloadblackbird-op-linux-c2fcdf6c427c9c2e305320d6ee82a8ca9f4fa961.tar.gz
blackbird-op-linux-c2fcdf6c427c9c2e305320d6ee82a8ca9f4fa961.zip
staging/lustre/llite: to configure max_cached_mb correctly
If there exists MGS conf_param to reduce the memory cache max_cached_mb it will fail because dt_exp is not initialized yet. It should just go ahead and configure it because certainly it have enough free LRU slot to deduct ccc_lru_left. Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com> Reviewed-on: http://review.whamcloud.com/11783 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3676 Reviewed-by: Bobi Jam <bobijam@gmail.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/lustre/lustre/llite/lproc_llite.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index e6a909e6faf0..aaa13bd3e8de 100644
--- a/drivers/staging/lustre/lustre/llite/lproc_llite.c
+++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c
@@ -399,9 +399,6 @@ static ssize_t ll_max_cached_mb_seq_write(struct file *file,
return -ERANGE;
}
- if (sbi->ll_dt_exp == NULL)
- return -ENODEV;
-
spin_lock(&sbi->ll_lock);
diff = pages_number - cache->ccc_lru_max;
spin_unlock(&sbi->ll_lock);
@@ -437,6 +434,11 @@ static ssize_t ll_max_cached_mb_seq_write(struct file *file,
if (diff <= 0)
break;
+ if (sbi->ll_dt_exp == NULL) { /* being initialized */
+ rc = -ENODEV;
+ break;
+ }
+
/* difficult - have to ask OSCs to drop LRU slots. */
tmp = diff << 1;
rc = obd_set_info_async(NULL, sbi->ll_dt_exp,
OpenPOWER on IntegriCloud