summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2015-03-26 20:47:10 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2015-07-09 13:35:31 -0700
commita28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1 (patch)
tree39c406c45d0828e4357d9469202c7a6b825cafee
parentce657611baf902f14ae559ce4e0787ead6712067 (diff)
downloadblackbird-op-linux-a28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1.tar.gz
blackbird-op-linux-a28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1.zip
hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
Removing unnecessary static buffers is good. Use the vsprintf %pV extension instead. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Mikulas Patocka <mikulas@twibright.com> Cc: stable@vger.kernel.org # v2.6.36+ Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/hpfs/super.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index cde044d41f69..68a9bed05628 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -52,17 +52,20 @@ static void unmark_dirty(struct super_block *s)
}
/* Filesystem error... */
-static char err_buf[1024];
-
void hpfs_error(struct super_block *s, const char *fmt, ...)
{
+ struct va_format vaf;
va_list args;
va_start(args, fmt);
- vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+ vaf.fmt = fmt;
+ vaf.va = &args;
+
+ pr_err("filesystem error: %pV", &vaf);
+
va_end(args);
- pr_err("filesystem error: %s", err_buf);
if (!hpfs_sb(s)->sb_was_error) {
if (hpfs_sb(s)->sb_err == 2) {
pr_cont("; crashing the system because you wanted it\n");
OpenPOWER on IntegriCloud