diff options
author | Wu Fengguang <fengguang.wu@intel.com> | 2015-07-24 14:16:10 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-07-27 00:59:16 -0700 |
commit | 9267135cca60674321139626f49077a4937d730e (patch) | |
tree | 5f9859756488a36861acaa5fbaa99840f0fc6e64 | |
parent | b469139e81ca8265fb4797c007f8d3338f4191a5 (diff) | |
download | blackbird-op-linux-9267135cca60674321139626f49077a4937d730e.tar.gz blackbird-op-linux-9267135cca60674321139626f49077a4937d730e.zip |
net: phy: dp83867: fix simple_return.cocci warnings
drivers/net/phy/dp83867.c:126:1-4: WARNING: end returns can be simpified
drivers/net/phy/dp83867.c:74:5-8: WARNING: end returns can be simpified if tested value is negative or 0
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/phy/dp83867.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 8a3bf5469892..32f10662f4ac 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -123,12 +123,8 @@ static int dp83867_of_init(struct phy_device *phydev) if (ret) return ret; - ret = of_property_read_u32(of_node, "ti,fifo-depth", + return of_property_read_u32(of_node, "ti,fifo-depth", &dp83867->fifo_depth); - if (ret) - return ret; - - return 0; } #else static int dp83867_of_init(struct phy_device *phydev) |