summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2019-09-17 13:20:14 +0200
committerRichard Weinberger <richard@nod.at>2019-11-25 22:42:57 +0100
commit5c1f33e2a03c0b8710b5d910a46f1e1fb0607679 (patch)
tree69a597877d45a4e069d37bb1f58dcc273c21d0bb
parente472c64aa4fa6150c6076fd36d101d667d71c30a (diff)
downloadblackbird-op-linux-5c1f33e2a03c0b8710b5d910a46f1e1fb0607679.tar.gz
blackbird-op-linux-5c1f33e2a03c0b8710b5d910a46f1e1fb0607679.zip
um: Don't trace irqflags during shutdown
In the main() code, we eventually enable signals just before exec() or exit(), in order to to not have signals pending and delivered *after* the exec(). I've observed SIGSEGV loops at this point, and the reason seems to be the irqflags tracing; this makes sense as the kernel is no longer really functional at this point. Since there's really no reason to use unblock_signals_trace() here (I had just done a global search & replace), use the plain unblock_signals() in this case to avoid going into the no longer functional kernel. Fixes: 0dafcbe128d2 ("um: Implement TRACE_IRQFLAGS_SUPPORT") Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Richard Weinberger <richard@nod.at>
-rw-r--r--arch/um/os-Linux/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c
index 8014dfac644d..c8a42ecbd7a2 100644
--- a/arch/um/os-Linux/main.c
+++ b/arch/um/os-Linux/main.c
@@ -170,7 +170,7 @@ int __init main(int argc, char **argv, char **envp)
* that they won't be delivered after the exec, when
* they are definitely not expected.
*/
- unblock_signals_trace();
+ unblock_signals();
os_info("\n");
/* Reboot */
OpenPOWER on IntegriCloud