summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@osdl.org>2005-10-05 12:09:31 -0700
committerDavid S. Miller <davem@davemloft.net>2005-10-05 12:09:31 -0700
commit42a39450f830c57432fd4e5644fa81f41ce7156d (patch)
tree3cf58d483f19f86c365f137acac46660901b0409
parentfab10fe37ad8dc4388fc444c89ef5aefe906354f (diff)
downloadblackbird-op-linux-42a39450f830c57432fd4e5644fa81f41ce7156d.tar.gz
blackbird-op-linux-42a39450f830c57432fd4e5644fa81f41ce7156d.zip
[TCP]: BIC coding bug in Linux 2.6.13
Missing parenthesis in causes BIC to be slow in increasing congestion window. Spotted by Injong Rhee. Signed-off-by: Stephen Hemminger <shemminger@osdl.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/tcp_bic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_bic.c b/net/ipv4/tcp_bic.c
index b940346de4e7..6d80e063c187 100644
--- a/net/ipv4/tcp_bic.c
+++ b/net/ipv4/tcp_bic.c
@@ -136,7 +136,7 @@ static inline void bictcp_update(struct bictcp *ca, u32 cwnd)
else if (cwnd < ca->last_max_cwnd + max_increment*(BICTCP_B-1))
/* slow start */
ca->cnt = (cwnd * (BICTCP_B-1))
- / cwnd-ca->last_max_cwnd;
+ / (cwnd - ca->last_max_cwnd);
else
/* linear increase */
ca->cnt = cwnd / max_increment;
OpenPOWER on IntegriCloud