diff options
| author | Tejun Heo <htejun@gmail.com> | 2006-03-25 02:58:13 +0900 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2006-03-24 23:04:29 -0500 |
| commit | 298a41ca41b4c933adc7b5a56a0adb0e1df2e556 (patch) | |
| tree | cb91595ee62afb244bc83b868095ef0c7339947e | |
| parent | aec5c3c1a929d7d79a420e943285cf3ba26a7c0d (diff) | |
| download | blackbird-op-linux-298a41ca41b4c933adc7b5a56a0adb0e1df2e556.tar.gz blackbird-op-linux-298a41ca41b4c933adc7b5a56a0adb0e1df2e556.zip | |
[PATCH] libata: cosmetic changes in ata_bus_softreset()
ata_bus_softreset() should return AC_ERR_* on failure not arbitrary
positive number. While at it, reformat comment above it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| -rw-r--r-- | drivers/scsi/libata-core.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c index 0aff888d9ecd..64f71df19ed1 100644 --- a/drivers/scsi/libata-core.c +++ b/drivers/scsi/libata-core.c @@ -2008,13 +2008,12 @@ static unsigned int ata_bus_softreset(struct ata_port *ap, */ msleep(150); - /* Before we perform post reset processing we want to see if - the bus shows 0xFF because the odd clown forgets the D7 pulldown - resistor */ - + * the bus shows 0xFF because the odd clown forgets the D7 + * pulldown resistor. + */ if (ata_check_status(ap) == 0xFF) - return 1; /* Positive is failure for some reason */ + return AC_ERR_OTHER; ata_bus_post_reset(ap, devmask); |
